Use colorbar guide as default for continuous color/fill scale (fixes #555) #558

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
3 participants
Collaborator

kohske commented May 17, 2012

No description provided.

Owner

hadley commented May 21, 2012

Could you please add a note to NEWS?

Collaborator

kohske commented May 22, 2012

Updated.

NEWS
@@ -32,6 +32,8 @@ MINOR FEATURES
coord, rather than by the scale only. Also, the `wise` argument is no
longer needed. (Thanks to Winston Chang and Kohske Takahashi)
+* Default guide for continuous color/fill scale is colorbar.
+
@wch

wch May 22, 2012

Collaborator

Since 0.9.1 has been released, I think you should put this on top, above the 0.9.1 section. (Later we will add the 0.9.2 section header.)

Collaborator

wch commented May 22, 2012

Should it be "colourbar" for spelling consistency?

Collaborator

kohske commented May 22, 2012

@wch Thanks, fixed.

Collaborator

wch commented May 22, 2012

I mean, should it be "colourbar" in the code?

Collaborator

kohske commented May 22, 2012

Sure, fixed ;-)

Collaborator

wch commented Jun 5, 2012

Rebased, edited, and merged in 81c847b.

@wch wch closed this Jun 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment