Revdepcheck 31/10/2025 #6718
Revdepcheck 31/10/2025 #6718
Conversation
teunbrand
left a comment
teunbrand
left a comment
There was a problem hiding this comment.
A few problems that should still be fixed on our end, but I don't know about the cases where documentation mismatches or expect_no_condition() picks up on warnings.
| Error in grid.Call(C_textBounds, as.graphicsAnnot(x$label), x$x, x$y, : | ||
| invalid mathematical annotation |
There was a problem hiding this comment.
Happens when labels are a list of calls/formulas. Affects 6 packages + frequently cause in vignette errors.
devtools::load_all("~/packages/ggplot2/")
#> ℹ Loading ggplot2
ggplot(mpg, aes(displ, hwy, colour = drv)) +
geom_point() +
scale_colour_discrete(
labels = c(~A, ~B, ~C)
)
#> Error in grid.Call(C_textBounds, as.graphicsAnnot(x$label), x$x, x$y, : invalid mathematical annotation
# In isolation
x <- textGrob(call("~"))
widthDetails(x)
#> Error in grid.Call(C_textBounds, as.graphicsAnnot(x$label), x$x, x$y, : invalid mathematical annotationCreated on 2025-11-03 with reprex v2.1.1
| ... | ||
| ══ Failed tests ════════════════════════════════════════════════════════════════ | ||
| ── Failure ('test-visualize.R:52:9'): Scree plots low dimensional ────────────── | ||
| Expected `plot_scree_adpc(model_selection, grid = TRUE)` to run without any conditions. |
There was a problem hiding this comment.
In #6541, we fixed mishandling NAs so they are now warned about properly. expect_no_condition() on code that is not 100% under your control is fragile.
|
|
||
| </details> | ||
|
|
||
| ## Newly broken | ||
|
|
||
| * checking examples ... ERROR | ||
| * checking tests ... ERROR |
| ERROR: compilation failed for package ‘bmgarch’ | ||
| * removing ‘/tmp/workdir/bmgarch/new/bmgarch.Rcheck/bmgarch’ |
There was a problem hiding this comment.
Note sure how ggplot2 would affect compilation of other packages.
| 12. └─ggplot2 (local) f(l = layers[[i]], d = data[[i]]) | ||
| 13. └─l$compute_position(d, layout) | ||
| 14. └─ggplot2 (local) compute_position(..., self = self) | ||
| 15. └─self$position$use_defaults(data, self$aes_params) |
There was a problem hiding this comment.
Need to mirror #6690 for Position$use_defaults() too
|
|
||
| </details> | ||
|
|
||
| ## Newly broken | ||
|
|
||
| * checking examples ... ERROR | ||
| * checking for code/documentation mismatches ... WARNING |
There was a problem hiding this comment.
Also function factory. Docs should be regenerated.
| ``` | ||
|
|
||
| # ANN2 | ||
| # ggsurveillance |
There was a problem hiding this comment.
expect_no_warning() for code that now correctly throws a warning.
|
|
||
| * checking package dependencies ... NOTE | ||
| ``` | ||
| Package which this enhances but |
There was a problem hiding this comment.
This is my bad, should have fallback for missing parameter in StatAlign$finish_layer()
| --- re-building ‘anova.Rmd’ using rmarkdown | ||
| ``` | ||
|
|
||
| # MetAlyzer |
There was a problem hiding this comment.
Another instance of the grid call error in vignettes
| ``` | ||
|
|
||
| # windfarmGA | ||
| # nett |
No description provided.