Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

New themes suitable for extending #692

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

jrnold commented Oct 14, 2012

I added some new themes which are not meant to be used directly but are designed to make extending and writing new themes easier. I noticed when writing themes that using theme_gray()or theme_bw() as the base theme required finding which non-top level elements were defined by those themes. theme_base0 is a complete theme that only defines top-level elements. theme_base_sizes defines various size elements that are used in theme_gray, and users are less likely to want to alter than colors. theme_base combines theme_base0 and theme_base_sizes.

Owner

hadley commented Oct 15, 2012

I like the idea, but I don't really like the names.

Contributor

jrnold commented Oct 15, 2012

I don't really have any good ideas on the names: theme_alpha, theme_foundation, theme_naught?

Contributor

jrnold commented Dec 22, 2012

I renamed theme_base to theme_foundation, and made theme_foundation the only exported function. This seems like a more intuitive name, because the theme provides a foundation to build new themes from.

Owner

hadley commented Feb 24, 2014

Does theme_blank()/theme_minimal() now do this?

@hadley hadley closed this Feb 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment