Improvements for documentation of shapes #717

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
@BrianDiggs
Contributor

BrianDiggs commented Nov 6, 2012

I've made a few improvements to the examples showing different shapes. I've submitted this at two separate commits within the same pull request. The first fixes errors in the documentation: there are 26 (0-25) shapes and shapes 19 and 20 do not have a fill. The second presents a better version of the shape catalog.

The first should be applied as it corrects factual errors; the second is optional, but I think a significant improvement.

BrianDiggs added some commits Nov 6, 2012

Fix errors in shape documentation
There are 26, not 25 shapes (shape 0 was not shown). Only symbols 21
through 25 have a fill option; 19 and 20 do not.
Improved graphic for shapes catalog
Revamped the graphic for showing the different shapes (0-25) utilizing
facet_wrap instead of staggering along the axes. Also using theme to
get rid of unnecessary elements, but retainging the grid lines that show
exactly where the points are centered. Changed the fill from black to
lightblue and made the symbols bigger.
R/aes-linetype-size-shape.r
#' # background colour (fill)
-#' s + geom_point(aes(shape = z), size = 4, colour = "Red") +
+#' s + geom_point(aes(shape = z), size = 10, colour = "Red") +

This comment has been minimized.

@hadley

hadley Nov 8, 2012

Member

This would be slightly cleaner if you put scale_shape_identity in the specification of s

@hadley

hadley Nov 8, 2012

Member

This would be slightly cleaner if you put scale_shape_identity in the specification of s

@BrianDiggs

This comment has been minimized.

Show comment
Hide comment
@BrianDiggs

BrianDiggs Jun 19, 2013

Contributor

Merged this into a different branch that is a bigger overhaul of aesthetic documentation, so this pull request is no longer needed/relevant.

Contributor

BrianDiggs commented Jun 19, 2013

Merged this into a different branch that is a bigger overhaul of aesthetic documentation, so this pull request is no longer needed/relevant.

@BrianDiggs BrianDiggs closed this Jun 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment