combine_elements should work by property name, not position #748

wants to merge 1 commit into


None yet

2 participants


This is a one line fix that makes sure combine_elements implements inheritance by property name rather than position. This allows child theme elements to have additional properties that the parent elements don't.

For example, I made a plot where text axis labels have graphical icons attached, by implementing a class that inherited from element_text, with additional properties and an element_grob method. This worked but required this small change.

hadley commented Feb 24, 2014

Could you please rebase/merge against master, re-document with the development version of roxygen2 (install_github("klutometis/roxygen) and resubmit?

@hadley hadley closed this Feb 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment