glue_sql() replaces all values with NULL when using * and vector has NA values

[carstenstann]

Glue 1.4.0 converts a vector containing NA_character_ to NULL when using * to collapse values, whereas 1.3.2 left NAs in place.

With 1.3.2:

> glue_sql("SELECT A FROM B WHERE B IN ({values*});", values= c(NA, "A","M","Q"), .con=dbConnect(RSQLite::SQLite(), ""))
<SQL> SELECT A FROM B WHERE B IN (NULL, 'A', 'M', 'Q');

With 1.4.0:

> library(glue)
> library(DBI)
> glue_sql("SELECT A FROM B WHERE B IN ({values*});", values= c(NA, "A","M","Q"), .con=dbConnect(RSQLite::SQLite(), ""))
<SQL> SELECT A FROM B WHERE B IN (NULL);
> 

This occurred for me on R 3.5.3 Platform x86_64-wmingw32/x64 as well as on R 3.6.3 (2020-02-29) Platform: x86_64-apple-darwin15.6.0 (64-bit)

Is this a bug? This seems related to #115 amd #130

[carstenstann]

Hi Jim,
Many thanks for the quick fix.
I tested the patch on my end. Works great!

library(glue)
library(DBI)
glue_sql("SELECT A FROM B WHERE A IN ({values*});", 
         values = c(NA, "A", "M","Q"), 
         .con = dbConnect(RSQLite::SQLite(), ":memory:"))
#> <SQL> SELECT A FROM B WHERE A IN (NULL, 'A', 'M', 'Q');

glue_sql("SELECT A FROM B WHERE A IN ({values*});", 
         values = c(1, NA, 2), 
         .con = dbConnect(RSQLite::SQLite(), ":memory:"))
#> <SQL> SELECT A FROM B WHERE A IN (1, NULL, 2);

sessionInfo()
#> R version 4.0.0 (2020-04-24)
#> Platform: x86_64-apple-darwin17.0 (64-bit)
#> Running under: macOS Catalina 10.15.4
#> 
#> Matrix products: default
#> BLAS:   /Library/Frameworks/R.framework/Versions/4.0/Resources/lib/libRblas.dylib
#> LAPACK: /Library/Frameworks/R.framework/Versions/4.0/Resources/lib/libRlapack.dylib
#> 
#> locale:
#> [1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8
#> 
#> attached base packages:
#> [1] stats     graphics  grDevices utils     datasets  methods   base     
#> 
#> other attached packages:
#> [1] DBI_1.1.0       glue_1.4.1.9000
#> 
#> loaded via a namespace (and not attached):
#>  [1] Rcpp_1.0.4.6    digest_0.6.25   magrittr_1.5    evaluate_0.14  
#>  [5] RSQLite_2.2.0   highr_0.8       rlang_0.4.6     stringi_1.4.6  
#>  [9] blob_1.2.1      vctrs_0.2.4     rmarkdown_2.1   tools_4.0.0    
#> [13] bit64_0.9-7     stringr_1.4.0   bit_1.1-15.2    xfun_0.13      
#> [17] yaml_2.2.1      compiler_4.0.0  memoise_1.1.0   htmltools_0.4.0
#> [21] knitr_1.28

Created on 2020-05-16 by the reprex package (v0.3.0)