Skip to content

DBI::SQL() elements should be collapsed correctly - #192

Merged
jimhester merged 2 commits into
tidyverse:masterfrom
shrektan:fix191
Jun 4, 2020
Merged

DBI::SQL() elements should be collapsed correctly#192
jimhester merged 2 commits into
tidyverse:masterfrom
shrektan:fix191

Conversation

@shrektan

@shrektan shrektan commented Jun 3, 2020

Copy link
Copy Markdown
Contributor

Closes #191

This is a regression of commit 1867133

@shrektan

shrektan commented Jun 4, 2020

Copy link
Copy Markdown
Contributor Author

Looks like the checking errors have nothing to do with the PR itself.

@jimhester

Copy link
Copy Markdown
Collaborator

Looks good, thanks!

@jimhester
jimhester merged commit a768e8a into tidyverse:master Jun 4, 2020
@shrektan
shrektan deleted the fix191 branch June 4, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

glue_sql() changed behavior for vectorized DBI::SQL() elements

2 participants