Give (potential) crayon calls special treatment #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennybc
force-pushed
the
glue-col-usability
branch
from
6ddc26a to
328bfda
Compare
Collaborator
|
LGTM, do you think we should add any tests for this? |
jimhester
approved these changes
Nov 24, 2021
Member
Author
|
I was thinking about tests. Given that we generally test in the presence of suggested packages, I guess a test of the "crayon absent" scenario will effectively be a manual test, but it won't hurt to record it officially and have an appropriate skip. |
Collaborator
|
You could mock |
Member
Author
|
The whole diff is covered now. I refactored the tests to use more standard testthat syntax. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196, fixes #138, fixes #221 (both already closed, but mentioning to get the links)
Previously
glue_col()was in some intermediate state between giving special treatment to crayon's coloring functions and not doing so. The docs (and source) strongly suggestedglue_col("{blue whatever}")would "just work" and yet that call definitely did not work.In this PR, we admit that crayon is special and simple usage of its colouring functions will now work without, e.g., attaching crayon or, in a package, importing its functions. Fancier compound styling functions, such as the concluding example of
glue_col()still require attaching or importing or the like, but I think that's (sort of) obvious. And much more rare usage, in any case.