glue_sql() collapses zero-length DBI::SQL object into DBI::SQL("NULL")#244
Merged
jennybc merged 5 commits intotidyverse:mainfrom Nov 29, 2021
Merged
glue_sql() collapses zero-length DBI::SQL object into DBI::SQL("NULL")#244jennybc merged 5 commits intotidyverse:mainfrom
DBI::SQL("NULL")#244jennybc merged 5 commits intotidyverse:mainfrom
Conversation
DBI::SQL("NULL")DBI::SQL("NULL")
Member
|
@jimhester Do you agree this is good to go? |
jimhester
approved these changes
Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a missed case of #134
The real use case that hurts in reality is :
When using Oracle database, the date object must be in format like
date'yyyy-mm-dd'. Thus, we need to do:Thus, when
datesis zero-length,sql_dateswould be zero-length as well, but it leads to an empty SQL string in the current version of glue.This PR fixes this. It results a valid SQL:
select * from table where ref_date in (NULL)