Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for upcoming glue 1.3.0 release #222

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Support for upcoming glue 1.3.0 release #222

merged 1 commit into from
Jul 5, 2018

Conversation

jimhester
Copy link
Contributor

glue::collapse() has been renamed to glue::glue_collapse(), this
provides support for both versions.

This should let you release google drive whenever is convenient rather than relying on the glue release. However I do plan to submit glue 1.3.0 in the next few weeks.

@jennybc
Copy link
Member

jennybc commented Jul 5, 2018

I think this line in the tests is also implicated:

function(x) as.character(glue::glue_collapse(c(x, y), sep = "-"))

`glue::collapse()` has been renamed to `glue::glue_collapse()`, this
provides support for both versions.
@jennybc
Copy link
Member

jennybc commented Jul 5, 2018

Thanks!

@jennybc jennybc merged commit 89bf736 into master Jul 5, 2018
@jennybc jennybc deleted the glue-1.3.0 branch May 8, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants