New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for upcoming glue 1.3.0 release #222

Merged
merged 1 commit into from Jul 5, 2018

Conversation

Projects
None yet
2 participants
@jimhester
Member

jimhester commented Jul 5, 2018

glue::collapse() has been renamed to glue::glue_collapse(), this
provides support for both versions.

This should let you release google drive whenever is convenient rather than relying on the glue release. However I do plan to submit glue 1.3.0 in the next few weeks.

@jennybc

This comment has been minimized.

Member

jennybc commented Jul 5, 2018

I think this line in the tests is also implicated:

function(x) as.character(glue::glue_collapse(c(x, y), sep = "-"))

Support for upcoming glue 1.3.0 release
`glue::collapse()` has been renamed to `glue::glue_collapse()`, this
provides support for both versions.

@jimhester jimhester force-pushed the glue-1.3.0 branch from 02e66cd to f23b55e Jul 5, 2018

@jennybc

This comment has been minimized.

Member

jennybc commented Jul 5, 2018

Thanks!

@jennybc jennybc merged commit 89bf736 into master Jul 5, 2018

6 checks passed

codecov/patch 66.66% of diff hit (target 0%)
Details
codecov/project 75.59% (target 5%)
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment