Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to run functions quietly - without output #163

Closed
daattali opened this issue May 25, 2020 · 0 comments · Fixed by #216
Closed

Provide a way to run functions quietly - without output #163

daattali opened this issue May 25, 2020 · 0 comments · Fixed by #216
Labels
feature a feature request or enhancement

Comments

@daattali
Copy link

I'm calling range_write() in a loop, which results in a lot of repetitive messages in my console

Editing "Untitled spreadsheet"
Writing to sheet "sheet1"
Editing "Untitled spreadsheet"
Writing to sheet "sheet1"
Editing "Untitled spreadsheet"
Writing to sheet "sheet1"

But actually it's a lot more than this. This makes it very difficult to notice if any warnings occured. I can shut it up with suppressMessages(), but that's not a great solution, I think it would be good for googlesheets4 to provide a mechanism to be quiet/non-verbose. I did a search for "verbose" and "quiet" in this codebase and couldn't find any, and I couldn't see anything in the docs or online, so my apologies if it does exist but I wasn't able to find it.

@jennybc jennybc added the feature a feature request or enhancement label May 25, 2020
jennybc added a commit that referenced this issue Mar 5, 2021
Closes #163

* All googlesheets4-originating messages can be turned off
* Use the cli package
jennybc added a commit that referenced this issue Mar 5, 2021
Closes #163

* All googlesheets4-originating messages can be turned off
* Use the cli package
@jennybc jennybc mentioned this issue Mar 7, 2021
jennybc added a commit that referenced this issue Mar 8, 2021
* Improve the user interface

Closes #163

* All googlesheets4-originating messages can be turned off
* Use the cli package

* Start using cli

* Get rid of message_glue()

* Delete (the unused) message_glue_data()

* Delete message_collapse()

* Delete warning_glue_data(), warning_collapse()

* Eliminate unused stop() wrappers

* Mask message()

* Introduce gs4_abort()

* abort_unsupported_conversion()

* Make gs4_abort() accept `message` with length > 1 (and names)

* Errors about length, number of rows, etc.

* Copy edits

* abort_bad_range()

* Bad input miscellany

* Missing input

* Can't find matching thing

* Switch to rlang::check_installed()

* Stragglers --> delete stop_glue()

* No real need to sub-sub-class the errors

* Inline is_testing()

* Write internal doc on messages and errors

* Cause more hyperlinks to happen

* Found some straggler rlang::abort() calls

* Line should have been deleted earlier

* Export and document local_gs4_quiet() and with_gs4_quiet()

* Seems more consistent with existing class name strategy

See vignettes/articles/function-class-name

Also it's probably better to use the full package name here

* Update WORDLIST

* Update NEWS

* Add issue numbers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants