Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retain as_factor.labelled method #414

Closed
jeffeaton opened this issue Nov 23, 2018 · 1 comment
Closed

retain as_factor.labelled method #414

jeffeaton opened this issue Nov 23, 2018 · 1 comment
Labels

Comments

@jeffeaton
Copy link

@jeffeaton jeffeaton commented Nov 23, 2018

While the class name change labelled to haven_labelled makes sense, is it possible to retain a method in the package for haven::as_factor.labelled for legacy purposes?

The class name change means that datasets saved with the former labelled class will need to be recreated. Retaining method for as_factor.labelled would reduce the pain a lot.

Thanks,
Jeff

@hadley hadley added the feature label Jan 5, 2019
@hadley hadley closed this in f89f2a7 Jan 24, 2019
@lock
Copy link

@lock lock bot commented Jul 23, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jul 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants