Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting for >= 24 hours #12

Closed
1 of 2 tasks
krlmlr opened this issue May 7, 2016 · 2 comments · Fixed by #15
Closed
1 of 2 tasks

Formatting for >= 24 hours #12

krlmlr opened this issue May 7, 2016 · 2 comments · Fixed by #15

Comments

@krlmlr
Copy link
Member

krlmlr commented May 7, 2016 •
edited

  • DdHH:MM:SS
  • HH:MM:SS

Currently shows hours modulo 24.
@krlmlr
Copy link
Member Author

krlmlr commented May 11, 2016

The first option can be enabled later by implementing a dhms class where only the format() method differs.

Need to pad with spaces if >= 100 hours.

This was referenced May 21, 2016
Closed
Merged
krlmlr added a commit that referenced this issue May 21, 2016
@krlmlr
Merge pull request #15 from rstats-db/feature/12-24-hours
eaabb9f 
- Times larger than 24 hours or with split seconds are now formatted correctly (#12, #13).
krlmlr pushed a commit that referenced this issue May 21, 2016
Merge tag 'v0.1-1'
30f6dfa 
- Subsetting keeps `hms` class (#16).
- Times larger than 24 hours or with split seconds are now formatted correctly (#12, #13).
- `format.hms()` right-justifies the output by padding with spaces from the left, `as.character.hms()` remains unchanged.
krlmlr pushed a commit that referenced this issue Jun 18, 2016
Merge tag 'v0.2'
b17e6aa 
Minor fixes and improvements.

- Subsetting keeps `hms` class (#16).
- `format.hms()` right-justifies the output by padding with spaces from the left, `as.character.hms()` remains unchanged.
- Times larger than 24 hours or with split seconds are now formatted correctly (#12, #13).
- Sub-second part is printed with up to six digits, for even smaller values trailing zeros are shown (#17).
This was referenced Jul 25, 2017
Closed
Closed
@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use custom formatting code tidyverse/hms
1 participant
@krlmlr