Skip to content

Advance deprecation for is.hms/as.hms #121

Closed

Description

@hadley

Marked as deprecated_soft() in 0.5.0, need to be advanced to deprecate_warn().

Activity

  1. added
    upkeepmaintenance, infrastructure, and similar
    on Jul 15, 2024
  2. moodymudskipper commented on Mar 21, 2025

    @moodymudskipper
    Contributor

    The 'hms' package uses the 'lifecycle' package to handle the deprecation cycle.

    From ? deprecate_soft :

    • deprecate_soft() warns only if the deprecated function is called directly, i.e. a user is calling a function they wrote in the global environment or a developer is calling it in their package. It does not warn when called indirectly, i.e. the deprecation comes from code that you don't control.

    • deprecate_warn() warns unconditionally.

    • deprecate_stop() fails unconditionally.`

    is.hms() and as.hms() contain calls to deprecated_soft() since some time, and it's time to use deprecated_warn() instead, this is a simple replacement (+ Update in the NEWS).

  3. added a commit that references this issue on Oct 25, 2025
  4. github-actions commented on Sep 20, 2026

    @github-actions
    Contributor

    This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

  5. locked and limited conversation to collaborators on Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wanted ❤️we'd love your help!upkeepmaintenance, infrastructure, and similar

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions