Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make as_hms() generic #81

Closed
krlmlr opened this issue Mar 30, 2020 · 1 comment · Fixed by #95
Closed

Make as_hms() generic #81

krlmlr opened this issue Mar 30, 2020 · 1 comment · Fixed by #95
Milestone
1.0.0

Comments

@krlmlr
Copy link
Member

krlmlr commented Mar 30, 2020

so that implementers can have methods that go beyond coercion, e.g., extract an hms component from a larger object.
@krlmlr krlmlr added this to the 1.0.0 milestone Jan 12, 2021
@krlmlr krlmlr mentioned this issue Jan 12, 2021
Merged
krlmlr added a commit that referenced this issue Jan 13, 2021
@krlmlr
Merge pull request #95 from tidyverse/f-81-as-hms
662c2b3 
- `as_hms()` is a generic again (#81).
@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

as_hms() is a generic again tidyverse/hms
1 participant
@krlmlr