Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lubridate test #23

Merged
merged 1 commit into from
Aug 26, 2016
Merged

Fix lubridate test #23

merged 1 commit into from
Aug 26, 2016

Conversation

vspinu
Copy link
Member

@vspinu vspinu commented Aug 26, 2016

Found this in the latest revdep check on the upcomming lubridate v1.6.0.

  - no more messages from lubridate
  - use cleaner lubridate api
@codecov-io
Copy link

codecov-io commented Aug 26, 2016

Current coverage is 100% (diff: 100%)

Merging #23 into master will not change coverage

@@           master   #23   diff @@
===================================
  Files           3     3          
  Lines          57    57          
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
  Hits           57    57          
  Misses          0     0          
  Partials        0     0          

Powered by Codecov. Last update 98d14cf...1a49170

@krlmlr krlmlr merged commit 80b2bfc into tidyverse:master Aug 26, 2016
@krlmlr
Copy link
Member

krlmlr commented Aug 26, 2016

Thanks! Does the check break entirely, will I need to update hms on CRAN soon?

@vspinu
Copy link
Member Author

vspinu commented Aug 26, 2016

Yes. It's a testhat error. I will upload lubridate and inform CRAN folks about the nature of the issue and that the issue has been fixed.

krlmlr added a commit that referenced this pull request Nov 22, 2016
- Fix `lubridate` test for compatibility with 1.6.0 (#23, @vspinu).
krlmlr added a commit that referenced this pull request Nov 23, 2016
- Fix `lubridate` test for compatibility with 1.6.0 (#23, @vspinu).
- NA values are formatted as `NA` (#22).
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants