Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#40 #44

Closed
wants to merge 5 commits into from
Closed

#40 #44

wants to merge 5 commits into from

Conversation

qgeissmann
Copy link
Contributor

Drafted a patch for #40 and #14.
Sorry, the first commits are related to #37, I was not sure if I should merge both branches...

@codecov
Copy link

codecov bot commented Sep 5, 2017

Codecov Report

Merging #44 into master will decrease coverage by 1.92%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #44      +/-   ##
=========================================
- Coverage   98.63%   96.7%   -1.93%     
=========================================
  Files           6       7       +1     
  Lines          73      91      +18     
=========================================
+ Hits           72      88      +16     
- Misses          1       3       +2
Impacted Files Coverage Δ
R/hms.R 97.36% <100%> (+0.07%) ⬆️
R/dhms.R 88.23% <88.23%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f4eaa3...38d154c. Read the comment docs.

@krlmlr
Copy link
Member

krlmlr commented Sep 15, 2017

Can you please merge master into your branch, or perhaps rebase and force-push? This will remove the commits that are already merged from the diff.

@krlmlr
Copy link
Member

krlmlr commented Sep 15, 2017

This will also need pillar support (see #43), either as a separate PR or as part of this PR.

@krlmlr
Copy link
Member

krlmlr commented Jan 13, 2021

Thanks for working on this. We could support a dhms class, I can't spend time on finishing this or maintaining this further. Closing for now, please open a new pull request if this is still desired.

@krlmlr krlmlr closed this Jan 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants