New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending %m+% to weeks and days #286

Closed
larmarange opened this Issue Dec 13, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@larmarange
Contributor

larmarange commented Dec 13, 2014

So far, %m+% works only with periods containing only years and months. Therefore it's not possible to do something like today() %m+% period(c(1,6),c("month","day)".

Would it be possible to extend %m+% in a such way that previous example would be equal to today %m+% period(1,"month") + period(6, "day")?

I would also allow to write more generic code when the unit is not known.

@vspinu vspinu added the enhancement label Dec 14, 2014

@vspinu

This comment has been minimized.

Member

vspinu commented Apr 28, 2015

We need this one way or another to fix #235. So I am willing to give it a stab. The only issue is that we will need a convention, do we sum years/months first or HMS first. I think years/months first is a bit more meaningful because the function is called %m%:)

@vspinu vspinu closed this in 00ff073 Apr 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment