Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_datetime creates time in UTC instead of supplied timezone #491

Closed
t-kalinowski opened this issue Oct 31, 2016 · 2 comments
Closed

make_datetime creates time in UTC instead of supplied timezone #491

t-kalinowski opened this issue Oct 31, 2016 · 2 comments
Labels
bug

Comments

@t-kalinowski
Copy link

@t-kalinowski t-kalinowski commented Oct 31, 2016

This is different from ISOdateTime

lubridate::make_datetime(2016, 10, 15, 0,0,0 , tz = "America/New_York")
[1] "2016-10-14 20:00:00 EDT"
ISOdatetime(2016, 10, 15, 0,0,0 , tz = "America/New_York")
[1] "2016-10-15 EDT"

from the docs:

make_datetime is a very fast drop-in replacement for base::ISOdate and base::ISOdatetime.

@vspinu vspinu added the bug label Nov 1, 2016
@vspinu
Copy link
Member

@vspinu vspinu commented Nov 1, 2016

Indeed. force_tz must be used instead. It will slow down the date creation considerably :(.

@vspinu vspinu closed this in 98ebf13 May 7, 2017
@vspinu
Copy link
Member

@vspinu vspinu commented May 7, 2017

Fixed, with new update functionality, this is very fast even for non-UTC tzones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.