New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format guessing code in parse_date_time broke my code ! #516

Closed
finlay opened this Issue Feb 9, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@finlay

finlay commented Feb 9, 2017

After reading the code, I realised what was happening, but it killed an afternoon.

I found that there is an issue here #308, and am now using the "exact" flag.

My only suggestion is that there should be something more in the documentation. Currently there is only one reference to the "training", without any explanation what it does:

exact: logical. If TRUE, orders parameter is interpreted as an exact strptime format
and no trainign or guessing are performed.

Perhaps a short description of what the training actually does, and why you might want to not use it. And perhaps a flag synonym like "training=FALSE" to make it easier to understand the code where it is used.

@vspinu

This comment has been minimized.

Show comment
Hide comment
@vspinu

vspinu Feb 9, 2017

Member

Yes, this is an thorny issue and better documentation is the only way to "fix" that.

Member

vspinu commented Feb 9, 2017

Yes, this is an thorny issue and better documentation is the only way to "fix" that.

@vspinu vspinu referenced this issue Feb 12, 2017

Merged

fixed typo #518

@vspinu

This comment has been minimized.

Show comment
Hide comment
@vspinu

vspinu May 7, 2017

Member

Fixing this by providing two new parameters train=TRUE and drop=FALSE. You have full control now on parsing.

Member

vspinu commented May 7, 2017

Fixing this by providing two new parameters train=TRUE and drop=FALSE. You have full control now on parsing.

@vspinu vspinu closed this in 34b263c May 7, 2017

@finlay

This comment has been minimized.

Show comment
Hide comment
@finlay

finlay commented May 8, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment