round_date interprets secs > 60 in unexpecteed way

[Holzhauer]

Thanks a lot for the helpful package!

x <- lubridate::ymd_hms("2009-08-03 12:01:57.11")
lubridate::round_date(x, "2 mins")
[1] "2009-08-03 12:02:00 UTC"

but

lubridate::round_date(x, "120 secs")
[1] "2009-08-03 12:01:00 UTC"

This is dangerous when handling durations e.g. in seconds, only: when the durations exceeds a minute, the result is unexpected. In this case, at least a warning should be issued.

[vspinu]

Actually truncation with seconds > 60 was never intended. So I would rather make this an error.

[rok]

Actually truncation with seconds > 60 was never intended. So I would rather make this an error.

@vspinu do you know what was the reason for this design? How about rounding to say 90 minutes?

[vspinu]

I thin the main reason is the complexity of implementation. I just didn't have enough time to push it through back then. No conceptual limitation AFAICJ.

[rok]

Would you be open to a PR changing this?

[vspinu]

Sure!

[vspinu]

I have just added a major enhancement to rounding functions - unit can be a date-time vector for arbitrary rounding.

[rok]

@vspinu great, I'll try to do something this weekend!