Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial argument matches in ceiling_date #672

Closed
wch opened this issue May 11, 2018 · 1 comment · Fixed by #816
Labels

Comments

@wch
Copy link
Member

@wch wch commented May 11, 2018

For example:

options(
  warnPartialMatchArgs = TRUE,
  warnPartialMatchAttr = TRUE,
  warnPartialMatchDollar = TRUE
)

ceiling_date(Sys.time(), "day")
#> Warning in (function (object, years = integer(), months = integer(), days = integer(),  :
#>   partial argument match of 'day' to 'days'
#> Warning in (function (object, years = integer(), months = integer(), days = integer(),  :
#>   partial argument match of 'hour' to 'hours'
#> Warning in (function (object, years = integer(), months = integer(), days = integer(),  :
#>   partial argument match of 'minute' to 'minutes'
#> Warning in (function (object, years = integer(), months = integer(), days = integer(),  :
#>   partial argument match of 'second' to 'seconds'
#> [1] "2018-05-12 CDT"

I believe the calls to update() here should have days instead of day, hours instead of hour, and so on.

@vspinu

This comment has been minimized.

Copy link
Member

@vspinu vspinu commented May 12, 2018

Right. Thanks for spotting and reporting this.

hadley added a commit that referenced this issue Nov 19, 2019
Fixes #672
@hadley hadley added bug wip labels Nov 19, 2019
@hadley hadley closed this in #816 Nov 20, 2019
hadley added a commit that referenced this issue Nov 20, 2019
Fixes #672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.