Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NA_Date_ and 0-length Date helpers #681

Closed
AshesITR opened this issue Jun 6, 2018 · 6 comments
Closed

Add NA_Date_ and 0-length Date helpers #681

AshesITR opened this issue Jun 6, 2018 · 6 comments

Comments

@AshesITR
Copy link

@AshesITR AshesITR commented Jun 6, 2018

Sometimes I find the need to explicitly set a date to NA (or specify an empty Date vector).
The former would be

NA_Date_ <- structure(NA_real_, class = "Date")

This is especially useful in conjuction with dplyr::if_else wich will error out on
dplyr::if_else(FALSE, NA_real_, lubridate::today()) and any other NA_...

The latter would be

Date <- function(length = 0L)structure(rep(NA_real_, length), class = "Date")

wich is very useful in allocating an empty data.frame with a date column.

@vspinu
Copy link
Member

@vspinu vspinu commented Jul 3, 2018

This is a good idea but it's so fundamental that should be tried with base R first. I could add NA_date_ and Date to lubridate but then I will have to add NA_POSIXct_ and POSIXct for consistency. I feel that all these belong in R proper.

Loading

@vspinu vspinu closed this in ea25ca6 Jul 3, 2018
@vspinu
Copy link
Member

@vspinu vspinu commented Jul 3, 2018

I decided to add these. We already do is.Date and is.POSIXct. Even if accepted into the core it almost surely won't be treating the tz argument as we want it - "UTC" by default.

Loading

@yakyak462
Copy link

@yakyak462 yakyak462 commented Jan 9, 2020

Hey -- sorry if this is obvious. But what is the workaround to not having NA_Date_ and needing to use if_else? The base R ifelse seems to breaks a lot of lubridate features.

Loading

@AshesITR
Copy link
Author

@AshesITR AshesITR commented Jan 10, 2020

@yakyak462 See the original issue: NA_Date_ <- structure(NA_real_, class = "Date").

Loading

@djbirke
Copy link

@djbirke djbirke commented Mar 4, 2021

@vspinu Would it be possible to also add NA_Duration_ (and possibly the equivalent for other timespan classes)? (I am happy to open a new issue for this, if you prefer.)

Loading

@vspinu
Copy link
Member

@vspinu vspinu commented Mar 5, 2021

@djbirke yes that would be useful. PRs more than welkome.

Loading

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue May 30, 2021
Version 1.7.10
==============

### NEW FEATURES

* `fast_strptime()` and `parse_date_time2()` now accept multiple formats and apply them in turn

### BUG FIXES

* [#926](tidyverse/lubridate#926) Fix incorrect division of intervals by months involving leap years
* Fix incorrect skipping of digits during parsing of the `%z` format

Version 1.7.9.2
===============

### NEW FEATURES

* [#914](tidyverse/lubridate#914) New `rollforward()` function
* [#928](tidyverse/lubridate#928) On startup lubridate now resets TZDIR to a proper directory when it is set to non-dir values like "internal" or "macOS" (a change introduced in R4.0.2)
* [#630](tidyverse/lubridate#630) New parsing functions `ym()` and `my()`

### BUG FIXES

* [#930](tidyverse/lubridate#930) `as.period()` on intervals now returns valid Periods with double fields (not integers)



Version 1.7.9
=============

### NEW FEATURES

* [#871](tidyverse/lubridate#893) Add `vctrs` support


### BUG FIXES

* [#890](tidyverse/lubridate#890) Correctly compute year in `quarter(..., with_year = TRUE)`
* [#893](tidyverse/lubridate#893) Fix incorrect parsing of abbreviated months in locales with trailing dot (regression in v1.7.8)
* [#886](tidyverse/lubridate#886) Fix `with_tz()` for POSIXlt objects
* [#887](tidyverse/lubridate#887) Error on invalid numeric input to `month()`
* [#889](tidyverse/lubridate#889) Export new dmonth function

Version 1.7.8
=============

### NEW FEATURES

* (breaking) Year and month durations now assume 365.25 days in a year consistently in conversion and constructors. Particularly `dyears(1) == years(1)` is now `TRUE`.
* Format and print methods for 0-length objects are more consistent.
* New duration constructor `dmonths()` to complement other duration constructors.
*
* `duration()` constructor now accepts `months` and `years` arguments.
* [#629](tidyverse/lubridate#629) Added `format_ISO8601()` methods.
* [#672](tidyverse/lubridate#672) Eliminate all partial argument matches
* [#674](tidyverse/lubridate#674) `as_date()` now ignores the `tz` argument
* [#675](tidyverse/lubridate#675) `force_tz()`, `with_tz()`, `tz<-` convert dates to date-times
* [#681](tidyverse/lubridate#681) New constants `NA_Date_` and `NA_POSIXct_` which parallel built-in primitive constants.
* [#681](tidyverse/lubridate#681) New constructors `Date()` and `POSIXct()` which parallel built-in primitive constructors.
* [#695](tidyverse/lubridate#695) Durations can now be compared with numeric vectors.
* [#707](tidyverse/lubridate#707) Constructors return 0-length inputs when called with no arguments
* [#713](tidyverse/lubridate#713) (breaking) `as_datetime()` always returns a `POSIXct()`
* [#717](tidyverse/lubridate#717) Common generics are now defined in `generics` dependency package.
* [#719](tidyverse/lubridate#719) Negative Durations are now displayed with leading `-`.
* [#829](tidyverse/lubridate#829) `%within%` throws more meaningful messages when applied on unsupported classes
* [#831](tidyverse/lubridate#831) Changing hour, minute or second of Date object now yields POSIXct.
* [#869](tidyverse/lubridate#869) Propagate NAs to all internal components of a Period object

### BUG FIXES

* [#682](tidyverse/lubridate#682) Fix quarter extraction with small `fiscal_start`s.
* [#703](tidyverse/lubridate#703) `leap_year()` works with objects supported by `year()`.
* [#778](tidyverse/lubridate#778) `duration()/period()/make_difftime()` work with repeated units
* `c.Period` concatenation doesn't fail with empty components.
* Honor `exact = TRUE` argument in `parse_date_time2`, which was so far ignored.

Version 1.7.4
=============

### NEW FEATURES

* [#658](tidyverse/lubridate#658) `%within%` now accepts a list of intervals, in which case an instant is checked if it occurs within any of the supplied intervals.

### CHANGES

* [#661](tidyverse/lubridate#661) Throw error on invalid multi-unit rounding.
* [#633](tidyverse/lubridate#633) `%%` on intervals relies on `%m+` arithmetic and doesn't produce NAs when intermediate computations result in non-existent dates.
* `tz()` always returns "UTC" when `tzone` attribute cannot be inferred.

### BUG FIXES

* [#664](tidyverse/lubridate#664) Fix lookup of period functions in `as.period`
* [#649](tidyverse/lubridate#664) Fix system timezone memoization

Version 1.7.3
=============

### BUG FIXES

* [#643](tidyverse/lubridate#643), [#640](tidyverse/lubridate#640), [#645](tidyverse/lubridate#645) Fix faulty caching of system timezone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants