Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare method needed between Duration and numerics for plotting in ggplot2 #695

Closed
dpseidel opened this issue Jul 19, 2018 · 2 comments
Closed

Comments

@dpseidel
Copy link
Member

@dpseidel dpseidel commented Jul 19, 2018

Plotting Duration objects in ggplot2 fails because there is no defined Compare method between numeric and Duration objects which is required by the underlying continuous scale calculations (reprex and discussion @ tidyverse/ggplot2#2414).

Is there a good reason why this method hasn't been implemented? I'm happy to submit a PR adding it if deemed appropriate.

@vspinu
Copy link
Member

@vspinu vspinu commented Jul 19, 2018

No good reason. difftime works with numeric so should durations. Would appreciate a PR for this (with a news entry). Thanks!

@mrucker
Copy link

@mrucker mrucker commented Apr 3, 2020

FYI, for anybody who runs into this bug as of April 2020 this fix still hasn't been released even though the issue is closed. Hopefully this will save others from spending a lot of time scratching their heads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants