New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fiscal_start to quarter when fiscal year doesn't begin in january #485

Merged
merged 1 commit into from Oct 22, 2016

Conversation

Projects
None yet
2 participants
@PedramNavid

PedramNavid commented Oct 21, 2016

This is a follow-up to Pull Request #427 , but I couldn't figure out how to use git properly to bring my old fork up so I deleted and started again.

I removed shift as requested, and created a fiscal_start parameter instead. Specifying a month other than 1 for the start of the fiscal year will shift the quarter (and the year if needed). For example, setting 11 for start will mean that Nov, Dec, Jan are all Q1. For Nov and Dec, the year will increment by 1 if with_year = TRUE. That is, 2013-11 will show as 2014.1 (1st quarter of 2014, as is convention when using fiscal quarters).

I have also added tests for quarters which did not exist previously.

Pedram

@vspinu vspinu merged commit aa43000 into tidyverse:master Oct 22, 2016

3 checks passed

codecov/patch 100% of diff hit (target 79.56%)
Details
codecov/project 79.80% (+0.24%) compared to 35cb3ea
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vspinu

This comment has been minimized.

Show comment
Hide comment
@vspinu

vspinu Oct 22, 2016

Member

Looks good. Thanks!

Member

vspinu commented Oct 22, 2016

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment