Skip to content

/ lubridate

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #401 ext] Return localized labels in month #508

Merged
merged 3 commits into from Jan 18, 2017
Merged

[Fix #401 ext] Return localized labels in month #508

merged 3 commits into from Jan 18, 2017

Conversation

@alberthkcheng
Copy link
Contributor

@alberthkcheng alberthkcheng commented Jan 16, 2017

Return localized month in the same way as weekday.
@alberthkcheng
[Fix #401 ext] Return localized labels in month
Loading status checks…
620dd5b
@alberthkcheng alberthkcheng force-pushed the alberthkcheng:albert branch from 1b79cba to 620dd5b Jan 16, 2017
@alberthkcheng
Copy link
Contributor Author

@alberthkcheng alberthkcheng commented Jan 16, 2017

pls check again the comment in #401 . thanks :)
@vspinu
Copy link
Member

@vspinu vspinu commented Jan 16, 2017 •
edited

Thanks, but this is not backward compatible, but I guess it's the right way to go anyways.

Could you please add a note to NEWS.md and check if there are tests for english locale?
@alberthkcheng
Update NEWS.md
349b9f5
@alberthkcheng
Add test case for english locale in accessor
253b63a
@alberthkcheng
Copy link
Contributor Author

@alberthkcheng alberthkcheng commented Jan 18, 2017

NEW.md and tests are added for month and wday
@vspinu vspinu merged commit ebd90d9 into tidyverse:master Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@alberthkcheng @vspinu
You can’t perform that action at this time.