New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #401 ext] Return localized labels in month #508

Merged
merged 3 commits into from Jan 18, 2017

Conversation

Projects
None yet
2 participants
@alberthkcheng
Contributor

alberthkcheng commented Jan 16, 2017

Return localized month in the same way as weekday.

@alberthkcheng

This comment has been minimized.

Show comment
Hide comment
@alberthkcheng

alberthkcheng Jan 16, 2017

Contributor

pls check again the comment in #401 . thanks :)

Contributor

alberthkcheng commented Jan 16, 2017

pls check again the comment in #401 . thanks :)

@vspinu

This comment has been minimized.

Show comment
Hide comment
@vspinu

vspinu Jan 16, 2017

Member

Thanks, but this is not backward compatible, but I guess it's the right way to go anyways.

Could you please add a note to NEWS.md and check if there are tests for english locale?

Member

vspinu commented Jan 16, 2017

Thanks, but this is not backward compatible, but I guess it's the right way to go anyways.

Could you please add a note to NEWS.md and check if there are tests for english locale?

@alberthkcheng

This comment has been minimized.

Show comment
Hide comment
@alberthkcheng

alberthkcheng Jan 18, 2017

Contributor

NEW.md and tests are added for month and wday

Contributor

alberthkcheng commented Jan 18, 2017

NEW.md and tests are added for month and wday

@vspinu vspinu merged commit ebd90d9 into tidyverse:master Jan 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment