Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly sets TZDIR env (#575) #600

Merged
merged 1 commit into from Nov 1, 2017
Merged

Conversation

@cderv
Copy link
Contributor

@cderv cderv commented Nov 1, 2017

Hi,

the fix a55725c for #575 has a small error that prevent the installation of lubridate.

Error: package or namespace load failed for 'lubridate':
 .onAttach failed in attachNamespace() for 'lubridate', details:
  call: Sys.setenv("TZDIR", tzdir)
  error: all arguments must be named
Erreur : le chargement a échoué

this PR changes this.

@vspinu vspinu merged commit 555a1e7 into tidyverse:master Nov 1, 2017
2 of 3 checks passed
2 of 3 checks passed
@codecov
codecov/patch 0% of diff hit (target 73.91%)
Details
@codecov
codecov/project 73.91% remains the same compared to d44d919
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vspinu
Copy link
Member

@vspinu vspinu commented Nov 1, 2017

Arh. I guess this is on windows. I wondered for a second how come that the checks haven't picked that up. Thanks!

@cderv
Copy link
Contributor Author

@cderv cderv commented Nov 1, 2017

yes it is on windows. should have mentioned it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants