Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix system timezone memoization. #649
The result of
Alternatively, you could not do the memoization; I'm not sure what the benefit or downside of that is.
This should fix several of the failures on CRAN.
This makes sense. But I think duplication should be better done within
Have you actually seen this with 1.7.3? You should see garbage returned by
Not sure. Empty tz which shows there is not "garbage".
I didn't put it there because there's no guarantee of it only being called once, whereas we know the
Yes, I've never used 1.7.2. It works the first time, but not on the second (or maybe third or fourth) call due to the pointers changing around.
The empty tz is printed out by the outer wrapper; this garbage shows up in some inner frames but is never printed out.
Mar 5, 2018
Encountered some strange error on version lubridate v1.7.2 (not be able to build the dev version on Windows because it reports that