Don't export functions created with setGeneric()

[hadley]

I'm pretty sure these are not necessary, and are actually harmful because they cause conflicts to be reported where conflicts don't actually exist. I confirmed this by reinstalling then running the following code:

library(lubridate)
#> 
#> Attaching package: 'lubridate'
#> The following object is masked from 'package:base':
#> 
#>     date
int1 <- interval(ymd("2001-01-01"), ymd("2002-01-01"))
int2 <- interval(ymd("2001-06-01"), ymd("2002-01-01"))
intersect(int1, int2)
#> [1] 2001-06-01 UTC--2002-01-01 UTC

[vspinu]

Does this help with #693?

[hadley]

Yes, it should do.

[hadley]

Ok, now I see:

library(dplyr)
#> 
#> Attaching package: 'dplyr'
#> The following objects are masked from 'package:stats':
#> 
#>     filter, lag
#> The following objects are masked from 'package:base':
#> 
#>     intersect, setdiff, setequal, union
library(lubridate)
#> 
#> Attaching package: 'lubridate'
#> The following objects are masked from 'package:base':
#> 
#>     date, intersect, setdiff, union

int1 <- interval(ymd("2001-01-01"), ymd("2002-01-01"))
int2 <- interval(ymd("2001-06-01"), ymd("2002-01-01"))
intersect(int1, int2)
#> [1] 2001-06-01 UTC--2002-01-01 UTC

^{Created on 2019-11-24 by the reprex package (v0.3.0)}

[vspinu]

There is a new revdep failure most likely due to this change. Any ideas what is going on? Can this be fixed on our side?

[vspinu]

My understanding is that raster defines its own generics, and thus overwrites ours when xROI imports both packages. Looks to me that we cannot do much here. It should be fixed on xROI or, better, on raster package, which should be ported on top of generics.

[hadley]

Yeah, agreed.

[vspinu]

rspatial/raster#107