New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typical methods for ordered factors and integers #44

Merged
merged 1 commit into from May 8, 2018

Conversation

Projects
None yet
2 participants
@jrnold
Contributor

jrnold commented Feb 26, 2017

Add typical methods for integer and ordered factor vectors.

  • integer: preserves the integer type instead of returning numeric
  • ordered factor: returns the level of the 50% quantile instead of the most frequent.

@jrnold jrnold changed the title from Typical.integer to Add typical methods for ordered factors and integers Feb 27, 2017

@hadley

This comment has been minimized.

Member

hadley commented Apr 26, 2018

Can you please add a bullet to NEWS? It should briefly describe the change (starting with name of the function), and crediting yourself with (@yourname, #issuenumber).

@jrnold

This comment has been minimized.

Contributor

jrnold commented May 7, 2018

I updated news. I bumped the package version to a dev version 0.1.1.9000

@hadley

This comment has been minimized.

Member

hadley commented May 7, 2018

Let me fix the version number (done).

I think something went wrong with your rebase 😞

Add integer and ordered methods for typical
- import stats::quantile
- add tests for typical
- fix docs for typical
- add missing `.Rd` file
- Add dev version; Update news

@jrnold jrnold force-pushed the jrnold:typical.integer branch from 7a15b3e to 8fb8e9a May 8, 2018

@jrnold

This comment has been minimized.

Contributor

jrnold commented May 8, 2018

Next best thing to burning it all down ... squashed the rebase until it worked.

@hadley hadley merged commit 1515ab8 into tidyverse:master May 8, 2018

3 checks passed

codecov/patch 100% of diff hit (target 50.97%)
Details
codecov/project 53.54% (+2.57%) compared to cc19a1c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented May 8, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment