Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map_lgl should .f instead of .p #134

Closed
hadley opened this issue Nov 18, 2015 · 4 comments
Closed

map_lgl should .f instead of .p #134

hadley opened this issue Nov 18, 2015 · 4 comments

Comments

@hadley
Copy link
Member

@hadley hadley commented Nov 18, 2015

@lionel- what do you think? I think it's better to be consistent within this group of functions, rather providing useful additional behaviour that requires more explanation.

@lionel-
Copy link
Member

@lionel- lionel- commented Nov 18, 2015

hmm yes it made more sense when it was a single probe() function.

@lionel-
Copy link
Member

@lionel- lionel- commented Dec 8, 2015

A side effect is that now map_if(), keep() etc don't work with logical vectors. So we should probably reinstate probe() for internal use.

@hadley
Copy link
Member Author

@hadley hadley commented Dec 8, 2015

And we clearly need some unit tests for those possibilities too

@lionel-
Copy link
Member

@lionel- lionel- commented Dec 8, 2015

yup I'll do it.

@lionel- lionel- closed this in 3beca35 Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants