New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map_lgl should .f instead of .p #134

Closed
hadley opened this Issue Nov 18, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@hadley
Member

hadley commented Nov 18, 2015

@lionel- what do you think? I think it's better to be consistent within this group of functions, rather providing useful additional behaviour that requires more explanation.

@lionel-

This comment has been minimized.

Member

lionel- commented Nov 18, 2015

hmm yes it made more sense when it was a single probe() function.

@lionel-

This comment has been minimized.

Member

lionel- commented Dec 8, 2015

A side effect is that now map_if(), keep() etc don't work with logical vectors. So we should probably reinstate probe() for internal use.

@hadley

This comment has been minimized.

Member

hadley commented Dec 8, 2015

And we clearly need some unit tests for those possibilities too

@lionel-

This comment has been minimized.

Member

lionel- commented Dec 8, 2015

yup I'll do it.

@lionel- lionel- closed this in 3beca35 Dec 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment