Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map_df() still calls dplyr::bind_rows() #328

Closed
jennybc opened this issue May 21, 2017 · 2 comments
Closed

map_df() still calls dplyr::bind_rows() #328

jennybc opened this issue May 21, 2017 · 2 comments

Comments

@jennybc
Copy link
Member

@jennybc jennybc commented May 21, 2017

Even though the NEWS says that dplyr is no longer dependency, I get test failures on another package that uses purrr, because there is no package called 'dplyr'.

It appears that map_df() still relies on dplyr::bind_rows():

library(purrr)
packageVersion("purrr")
#> [1] '0.2.2.9000'
map_df
#> function (.x, .f, ..., .id = NULL) 
#> {
#>     .f <- as_mapper(.f, ...)
#>     res <- map(.x, .f, ...)
#>     dplyr::bind_rows(res, .id = .id)
#> }
#> <environment: namespace:purrr>

There are other uses of dplyr too. Am I just missing something?

@lionel-
Copy link
Member

@lionel- lionel- commented May 21, 2017

While dplyr is no longer a hard dependency, purrr still relies on it for binding data frames. So you need to be explicit about the dependency in the description file by adding dplyr to Imports:.

@lionel- lionel- closed this as completed May 21, 2017
@lionel-
Copy link
Member

@lionel- lionel- commented May 21, 2017

We should probably mention that dplyr needs to be installed in the documentation of those functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants