New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain dimnames in array_branch and array_tree #584

Merged
merged 6 commits into from Nov 28, 2018

Conversation

Projects
None yet
2 participants
@flying-sheep
Copy link
Contributor

flying-sheep commented Nov 27, 2018

By not resetting dim(array) without need, the return value retains its dimnames

@lionel-

This comment has been minimized.

Copy link
Member

lionel- commented Nov 27, 2018

Could you provide a motivation for this change please? Ideally the motivation would be provided in a NEWS bullet explaining the change and would be covered by unit tests.

@flying-sheep

This comment has been minimized.

Copy link
Contributor

flying-sheep commented Nov 27, 2018

Sure, done!

@flying-sheep

This comment has been minimized.

Copy link
Contributor

flying-sheep commented Nov 28, 2018

OK, this looks good to go!

Show resolved Hide resolved R/arrays.R Outdated

@flying-sheep flying-sheep force-pushed the flying-sheep:patch-1 branch from d93a851 to da5a769 Nov 28, 2018

@lionel- lionel- force-pushed the flying-sheep:patch-1 branch from f3f3da0 to 1cf3a52 Nov 28, 2018

@lionel- lionel- merged commit 22495d1 into tidyverse:master Nov 28, 2018

4 checks passed

codecov/patch 100% of diff hit (target 93.28%)
Details
codecov/project 93.32% (+0.03%) compared to b4ae036
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lionel-

This comment has been minimized.

Copy link
Member

lionel- commented Nov 28, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment