Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add none function, to complement some/every #735

Merged
merged 4 commits into from Jan 31, 2020

Conversation

AliciaSchep
Copy link
Contributor

@AliciaSchep AliciaSchep commented Jan 31, 2020

Fixes #664

Adds a none function, and tests for it. Renames the files b/c they now include none function too.

@lionel- lionel- added the tidy-dev-day 🤓 label Jan 31, 2020
Copy link
Member

@lionel- lionel- left a comment

Looking good! Can you also add a NEWS bullet and an example please?

@@ -1,10 +1,11 @@
#' Do every or some elements of a list satisfy a predicate?
#' Do every, some, or none of the elements of a list satisfy a predicate?
Copy link
Member

@lionel- lionel- Jan 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick, can you use Oxford comma please

@AliciaSchep
Copy link
Contributor Author

@AliciaSchep AliciaSchep commented Jan 31, 2020

Added examples, NEWS bullet, and removed the comma.

@lionel- lionel- merged commit 396b56c into tidyverse:master Jan 31, 2020
1 of 2 checks passed
@lionel-
Copy link
Member

@lionel- lionel- commented Jan 31, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tidy-dev-day 🤓
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants