Skip to content
Permalink
Branch: master
Commits on Mar 6, 2017
  1. change message behavior of read_table (#630)

    jrnold authored and jimhester committed Mar 6, 2017
    * change message behavior of read_table
    
    When using `read_table` I was surprised to get a print out of the `spec` even after specifying the `col_type` argument. This is different than `read_csv` and most of the other functions in `readr`.
    
    Currently the behavior of `read_table` is to print the spec whenever `progress = TRUE`. This changes the behavior to be similar to that of the other functions in **readr**: print if `col_types` is `NULL`.
    
    * Add to NEWS
Commits on Feb 25, 2017
  1. fix merge error

    jrnold committed Feb 25, 2017
    weird things happened to NEWS.md. They are fixed now.
  2. Merge 'tidyverse/master' into fwf_cols

    jrnold committed Feb 25, 2017
  3. add bullet point to NEWS.md

    jrnold committed Feb 25, 2017
  4. convert numeric constants in fwf functions

    jrnold committed Feb 25, 2017
    Convert some numeric constants to integer constants so that addition/subtraction does not coerce columns to numeric if they were integer. This is not a big deal, but since the positions represent integers anyways, it might as well keep them as such if they are already specified as such.
  5. respond to hadley's comments

    jrnold committed Feb 25, 2017
    Revert this section in read_fwf since it is unnecessary to handle data list objects with the availability of fwf_cols
    
    See #616
  6. fix tests

    jrnold committed Feb 25, 2017
    - removed tests that failed after removing features in fwf_cols in previous commits
    - remove test that failed because fwf_positions changes columns to numeric
  7. Fix indenting issues

    jrnold committed Feb 25, 2017
    See comments in #616
  8. respond to hadley's comments

    jrnold committed Feb 25, 2017
    This seems too flexible, so I'll change it to just use ...
    
    See #616
  9. respond to hadley's comments

    jrnold committed Feb 25, 2017
    Remove a try() call since, the preference is for errors to bubble up to users.
    
    See #616
  10. respond the hadley's comments

    jrnold committed Feb 25, 2017
    Revert added newline
    
    See #616
  11. respond to hadley's comments

    jrnold committed Feb 25, 2017
    This is too complicated; since we have fwf_cols, don't worry about list inputs.
    
    See #616
  12. respond to hadley's comments

    jrnold committed Feb 25, 2017
    Add widths form of fwf_cols to documentation
    
    See #616
  13. respond to hadley's comments

    jrnold committed Feb 25, 2017
    Move fwf_col_names function lower in file.
    
    See #616
  14. merge

    jrnold committed Feb 25, 2017
  15. misc

    jrnold committed Feb 25, 2017
Commits on Feb 24, 2017
  1. fix failing tests

    jrnold committed Feb 24, 2017
Commits on Feb 23, 2017
  1. Updates to fwf_* column position functions

    jrnold committed Feb 23, 2017
    - read_fwf arg col_positions will check for column names and whether the data frame is widths or a start/end data frame.
    - rewrite fwf_cols to accept named args of length 1 or 2. This makes it more concise. Also accept a data frame as the first argument
    - More checks for argument validity
    - Use tibbles instead of lists where appropriate
    
    Some tests failing. Still need to debug.
  2. Add fwf_cols function

    jrnold committed Feb 18, 2017
    This adds a helper function `fwf_cols` that is a more intuitive way of specifying fixed width column start and end points. While `fwf_positions` requires three vectors for start, end, and names, `fwf_cols` accepts a named list of length-2 vectors of the column start and end positions.
  3. Fix failed Travis build

    jrnold committed Feb 20, 2017
    It needs the .Rd file.
  4. fix example for fwf_cols

    jrnold committed Feb 18, 2017
  5. Add fwf_cols function

    jrnold committed Feb 18, 2017
    This adds a helper function `fwf_cols` that is a more intuitive way of specifying fixed width column start and end points. While `fwf_positions` requires three vectors for start, end, and names, `fwf_cols` accepts a named list of length-2 vectors of the column start and end positions.
Commits on Feb 20, 2017
  1. Fix failed Travis build

    jrnold committed Feb 20, 2017
    It needs the .Rd file.
Commits on Feb 18, 2017
  1. fix example for fwf_cols

    jrnold committed Feb 18, 2017
  2. Add fwf_cols function

    jrnold committed Feb 18, 2017
    This adds a helper function `fwf_cols` that is a more intuitive way of specifying fixed width column start and end points. While `fwf_positions` requires three vectors for start, end, and names, `fwf_cols` accepts a named list of length-2 vectors of the column start and end positions.
Commits on Jan 21, 2017
  1. change progress defaults

    jrnold committed Jan 21, 2017
    Change defaults for displaying the progress bar to be similar to those for dplyr. Currently, the progress bar defaults to display when not interactive. However, it will still display in knitr documents if they are compiled in an interactive session.
    
    This patch defines an unexported function `progress_defaults` which sets checks for an option `readr.show_progress`, whether it is interactive, and whether it is in a knitr document (`knitr.in.progress`). This is equivalent to how `dplyr` defaults for showing a progress bar.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.