Skip to content

parse_guess doesn't ignore NA values, thus rendering the na parameter less useful. #1041

Description

@jmarshallnz

I'd expect that parse_guess would first remove NA strings prior to guessing the type. Otherwise anything with an NA encoded as a string (rather than _NA_character) would not be guessed correctly, as guess_parser does not filter NA strings.


> parse_guess(c("123", NA))
[1] 123  NA
> parse_guess(c("123", "NA"), na="NA")
[1] "123" NA  

Notice that it is converting the "NA" to NA, but not prior to parsing.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions