New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement write_tsv #135

Closed
hadley opened this Issue Apr 16, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@hadley
Member

hadley commented Apr 16, 2015

Should be simple generalisation of write_csv. Use same strategy to only quote when needed.

@npjc

This comment has been minimized.

Contributor

npjc commented Apr 30, 2015

@hadley I've been reading through your r-pkgs book book and I'm learning me how to package. It's very helpful! Anyway since I wanted to walkthrough the process with a simple use case:

i decided to make writer where I (stole! and) generalised readr:::stream_csv() to stream_delim() and used it to implement:

  • write_csv()

  • write_tsv()

  • write_delim()

    I also threw in naive wrappers around base::saveRDS to make:

  • write_rds()

  • write_compressed_rds()

Now although this was purely an exercise to get learning.. it got me wondering: If readr is about reading then should you have a writer (or maybe saver since it has 5 letters) package? And if readr is really about stable/streaming data input and output should it then be renamed to reflect this? I guess I'm really asking about the phylosophy of how package-happy one should be when developing thingamabobs.

I hope it's helpful with this issue!
If you have any thoughts rep(c('thanks', '!'),1E6)

@hadley

This comment has been minimized.

Member

hadley commented Apr 30, 2015

I'd rather just keep all the functionality in readr - I don't think it's too awful to keep the name as readr, since that is the primary purpose. Do you want to do a pull request?

@npjc

This comment has been minimized.

Contributor

npjc commented Apr 30, 2015

@hadley okee: see #157

@hadley hadley closed this Jul 10, 2015

@lock lock bot locked and limited conversation to collaborators Sep 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.