/readr

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

col_date or col_datetime does not support %I hour format for AM/PM tagged hours #340

Closed
bdb67 opened this Issue Dec 28, 2015 · 1 comment

Comments

Assignees

@jimhester jimhester

Labels
collector feature
Projects
None yet
Milestone
No milestone
3 participants
@bdb67 @hadley @jimhester
@bdb67

bdb67 commented Dec 28, 2015 •
edited by hadley

For example, parsing date "12/31/1991 6:00:00 PM", given date format = "%m/%d/%Y %I" will return an error.

readr::parse_datetime("12/31/1991 6:00 PM", "%m/%d/%Y %I")
@hadley

This comment has been minimized.

Sign in to view
Member

hadley commented Jun 1, 2016

You mean

readr::parse_datetime("12/31/1991 6:00 PM", "%m/%d/%Y %I:%m %p")

right?

Adding %I support should be pretty easy

@hadley hadley added feature ready collector labels Jun 1, 2016

@jimhester jimhester referenced this issue Jun 8, 2016

Merged

Support %I for 12 hour times #426

@jimhester jimhester self-assigned this Jun 8, 2016

@jimhester jimhester added in progress and removed ready labels Jun 8, 2016

@jimhester jimhester closed this in #426 Jun 9, 2016

@jimhester jimhester removed the in progress label Jun 9, 2016

@lock lock bot locked and limited conversation to collaborators Sep 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.