/readr

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse_time() invalid token: 'NA' #398

Closed
kspaff opened this Issue Apr 25, 2016 · 0 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kspaff
@kspaff

kspaff commented Apr 25, 2016

parse_time() does not handle NA as I would expect. Very simple to reproduce:

parse_time('NA')
Error: Invalid token
parse_integer('NA')
[1] NA

Looks like there might be a missing break statement here:
https://github.com/hadley/readr/blob/master/src/Collector.cpp:355

@hadley hadley closed this in 3aab375 Jun 1, 2016

@hadley hadley referenced this issue Jun 2, 2016

Closed

Still having problem parsing time that is NA #344

noamross added a commit to noamross/readr that referenced this issue Jun 2, 2016

@hadley @noamross
Add missing return. 
Fixes tidyverse#398
cc899f3

@lock lock bot locked and limited conversation to collaborators Sep 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.