Skip to content

/ readr

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse_factor should always generate explicit NAs #541

Closed
hadley opened this issue Oct 28, 2016 · 1 comment
Closed

parse_factor should always generate explicit NAs #541

hadley opened this issue Oct 28, 2016 · 1 comment
Labels
collector feature

Comments

@hadley
Copy link
Member

@hadley hadley commented Oct 28, 2016

Or it should at least be an option
@hadley
Copy link
Member Author

@hadley hadley commented Dec 22, 2016

(i.e. the NA's should be included in the vector of levels, not just appear as NAs in the underlying integer vector)
jimhester added a commit that referenced this issue Jan 31, 2017
@jimhester
`parse_factor()` gains a `include_na` argument
Loading status checks…
2d4d208 
Which includes `NA` in the factor levels.

Fixes #541
@jimhester jimhester mentioned this issue Jan 31, 2017
Closed
jimhester added a commit that referenced this issue Jan 31, 2017
@jimhester
`parse_factor()` gains a `include_na` argument
Loading status checks…
f3778f2 
Which includes `NA` in the factor levels.

Fixes #541
jimhester added a commit that referenced this issue Feb 22, 2017
@jimhester
`parse_factor()` gains a `include_na` argument
8e1da57 
Which includes `NA` in the factor levels.

Fixes #541
@jimhester jimhester closed this in d3cdcd2 Feb 22, 2017
@lock lock bot locked and limited conversation to collaborators Sep 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
collector feature
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@hadley