/readr

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse_factor should always generate explicit NAs #541

Closed
hadley opened this Issue Oct 28, 2016 · 1 comment

Comments

Assignees
No one assigned
Labels
collector feature
Projects
Needs Review in jimhester
Milestone
No milestone
1 participant
@hadley
@hadley
Member

hadley commented Oct 28, 2016

Or it should at least be an option

@hadley hadley added collector feature labels Dec 22, 2016

@hadley

This comment has been minimized.

Sign in to view
Member

hadley commented Dec 22, 2016

(i.e. the NA's should be included in the vector of levels, not just appear as NAs in the underlying integer vector)

jimhester added a commit that referenced this issue Jan 31, 2017

@jimhester
`parse_factor()` gains a `include_na` argument, to include `NA` in th… 
…e factor levels

Fixes #541
Loading status checks…
7e400e9

jimhester added a commit that referenced this issue Jan 31, 2017

@jimhester
`parse_factor()` gains a `include_na` argument 
Which includes `NA` in the factor levels.

Fixes #541
Loading status checks…
2d4d208

@jimhester jimhester referenced this issue Jan 31, 2017

Closed

`parse_factor()` gains a `include_na` argument #592

jimhester added a commit that referenced this issue Jan 31, 2017

@jimhester
`parse_factor()` gains a `include_na` argument 
Which includes `NA` in the factor levels.

Fixes #541
Loading status checks…
f3778f2

@jimhester jimhester added this to DONE in jimhester Feb 2, 2017

@jimhester jimhester moved this from DONE to Needs Review in jimhester Feb 10, 2017

jimhester added a commit that referenced this issue Feb 21, 2017

@jimhester
`parse_factor()` gains a `include_na` argument 
Which includes `NA` in the factor levels.

Fixes #541
75c636d

jimhester added a commit that referenced this issue Feb 22, 2017

@jimhester
`parse_factor()` gains a `include_na` argument 
Which includes `NA` in the factor levels.

Fixes #541
8e1da57

@jimhester jimhester closed this in d3cdcd2 Feb 22, 2017

@lock lock bot locked and limited conversation to collaborators Sep 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.