Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse_time fails if 12 pm #579

Closed
hadley opened this issue Jan 14, 2017 · 0 comments
Closed

parse_time fails if 12 pm #579

hadley opened this issue Jan 14, 2017 · 0 comments
Labels

Comments

@hadley
Copy link
Member

@hadley hadley commented Jan 14, 2017

parse_time("12:01 PM")

Because DateTimeParser.hour always adds 12. It should subtract 12 if hour is already 12.

From @cwickham

jimhester added a commit to jimhester/readr that referenced this issue Jan 24, 2017
jimhester added a commit that referenced this issue Jan 24, 2017
@lock lock bot locked and limited conversation to collaborators Sep 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant