/readr

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse_time fails if 12 pm #579

Closed
hadley opened this Issue Jan 14, 2017 · 0 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
1 participant
@hadley
@hadley
Member

hadley commented Jan 14, 2017 

parse_time("12:01 PM")

Because DateTimeParser.hour always adds 12. It should subtract 12 if hour is already 12.

From @cwickham

@hadley hadley added bug collector labels Jan 14, 2017

jimhester added a commit to jimhester/readr that referenced this issue Jan 23, 2017

@jimhester
`parse_time()` now correctly handles 12 AM/PM 
Fixes tidyverse#579
2737654

@jimhester jimhester referenced this issue Jan 23, 2017

Merged

`parse_time()` now correctly handles 12 AM/PM #584

jimhester added a commit to jimhester/readr that referenced this issue Jan 24, 2017

@jimhester
`parse_time()` now correctly handles 12 AM/PM 
Fixes tidyverse#579
6f93d5b

@jimhester jimhester closed this in #584 Jan 24, 2017

jimhester added a commit that referenced this issue Jan 24, 2017

@jimhester
`parse_time()` now correctly handles 12 AM/PM (#584) 
Fixes #579
Loading status checks…
7ef248a

@jimhester jimhester referenced this issue Feb 22, 2017

Closed

parse_time() fails for "12:??PM" #618

@lock lock bot locked and limited conversation to collaborators Sep 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.