Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_csv documentation examples #635

Closed
pgensler opened this issue Mar 15, 2017 · 6 comments
Closed

write_csv documentation examples #635

pgensler opened this issue Mar 15, 2017 · 6 comments
Labels
feature a feature request or enhancement tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day

Comments

@pgensler
Copy link

It would be really nice to have some clearer documentation with write_csv that you could do a simple example like this::

write_csv(wine, "wine.csv") where the function writes "wine.csv" to you default working directory, unless otherwise specified. Currently the documentation makes it sound like you specify only a file path, with no file name, and then no confirmation is outputted stating it was successful.

On a side note, are the examples in the documentation intended to be a MWE/ or a unit test? As I am 1000% for unit testing code, some of these examples seem more like that style, and less concise, clear and brief examples. I'd love to help with providing some, but I'm not sure if this is a roxygen thing when you make documentation for a package. Thanks for such a great package!

@msalganik
Copy link

+1

@jimhester
Copy link
Collaborator

Using tempfiles in the example avoids polluting the users' working directory when the examples are run.
If you want to suggest more clear documentation please do! You can simply modify the comments above the functions in R/write.R, we can handle the roxygen side of things.

@vojtechhuser
Copy link

+1 for examples. even if they polute.

@jimhester jimhester added the feature a feature request or enhancement label Dec 7, 2017
@hadley hadley added the tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day label Jan 4, 2019
@skaltman
Copy link

I'll take this!

@pgensler
Copy link
Author

FYI, not sure how simplistic/complex you would like the examples to be, but it might be a good idea to utilize the here package in the examples to emphasize best practices within the tidyverse?

@lock
Copy link

lock bot commented Jul 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jul 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day
Projects
None yet
Development

No branches or pull requests

6 participants