Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider promotion of integer -> double tokenizers #652

Closed
kevinushey opened this issue Apr 21, 2017 · 2 comments
Closed

Consider promotion of integer -> double tokenizers #652

kevinushey opened this issue Apr 21, 2017 · 2 comments

Comments

@kevinushey
Copy link

@kevinushey kevinushey commented Apr 21, 2017

For certain numeric columns, it's possible that the first entries are representable as integer, with only the later entries being representable as double. In such a case, calls to read_csv() can fail as the inferred integer tokenizer will fail to tokenize those later entries.

Would it be possible for readr to instead just promote the tokenizer from integer to double on the fly in such a case?

@jimhester
Copy link
Member

@jimhester jimhester commented Dec 7, 2017

We no longer guess integer columns by default, so I am closing this.

@jimhester jimhester closed this Dec 7, 2017
@lock
Copy link

@lock lock bot commented Sep 25, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants