Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardise_path() should use case-insensitive comparison #794

Closed
hadley opened this issue Feb 15, 2018 · 2 comments
Closed

standardise_path() should use case-insensitive comparison #794

hadley opened this issue Feb 15, 2018 · 2 comments
Labels

Comments

@hadley
Copy link
Member

@hadley hadley commented Feb 15, 2018

i.e. tolower(tools::file_ext(path))

tidyverse/haven#298

@jimhester
Copy link
Member

@jimhester jimhester commented May 4, 2018

I am not entirely sure extensions differing in case should be the same thing, but as this situation is likely confusing for users probably best if we do this.

@lock
Copy link

@lock lock bot commented May 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators May 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants