Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse_factor() make levels = NULL the default #862

Closed
brianstamper opened this issue Jun 5, 2018 · 2 comments · Fixed by #877
Closed

parse_factor() make levels = NULL the default #862

brianstamper opened this issue Jun 5, 2018 · 2 comments · Fixed by #877
Labels
feature a feature request or enhancement good first issue ❤️ good issue for first-time contributors
Milestone
1.2.0

Comments

@brianstamper
Copy link

Since #497 parse_factor() has the option to automatically figure out levels by setting levels = NULL. Shouldn't this be the default, so that, for example, a call to col_factor() without arguments would make use of this feature?

I came across this because I was intuitively expecting col_factor() to do this already. Seems it wouldn't break any existing code since currently col_factor() alone throws an error.
@brianstamper
Copy link
Author

Related to #810 about parse_factor() not having a shortcode.

@jimhester jimhester added feature a feature request or enhancement good first issue ❤️ good issue for first-time contributors labels Jul 27, 2018
@mikmart mikmart mentioned this issue Aug 2, 2018
Merged
@jimhester jimhester added this to the 1.2.0 milestone Nov 15, 2018
jimhester pushed a commit that referenced this issue Nov 16, 2018
@mikmart @jimhester
Use levels = NULL as default in parse_factor() (#862) (#877)
9e946a1 
Also add f as shortcode for col_factor()

Fixes #877
Fixes #810
@lock
Copy link

lock bot commented May 15, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators May 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature a feature request or enhancement good first issue ❤️ good issue for first-time contributors
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Use levels = NULL as default in parse_factor() (#862) mikmart/readr
2 participants
@jimhester @brianstamper