Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change path argument to file in write_csv #1110

Merged
merged 3 commits into from Sep 11, 2020
Merged

Change path argument to file in write_csv #1110

merged 3 commits into from Sep 11, 2020

Conversation

brianrice2
Copy link
Contributor

@brianrice2 brianrice2 commented Jun 13, 2020

The read_* and write_* functions use different parameters of
file vs path, which can be confusing. Replaced path argument with file
in write.R, similar to existing structure in read_delim.R.

Also updated accompanying unit test in test-write.R. Results
remain 759 OK / 7 Fail / 1 Warning.

Fixes #964.

brianrice2 and others added 3 commits Jun 13, 2020
The read_* and write_* functions use different parameters of
file vs path, which can be confusing. Replaced path argument with file
in write.R, similar to existing structure in read_delim.R.

Also updated accompanying unit test in test-write.R. Results
remain 759 OK / 7 Fail / 1 Warning.

Fixes #964.
@jimhester jimhester merged commit f6857b5 into tidyverse:master Sep 11, 2020
@jimhester
Copy link
Member

jimhester commented Sep 11, 2020

Thank you!

@brianrice2 brianrice2 deleted the file-vs-path-argument branch Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

file vs path argument to read_* and write_*
2 participants