Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in fwf_empty #222

Merged
merged 2 commits into from Jul 23, 2015
Merged

Fixed bug in fwf_empty #222

merged 2 commits into from Jul 23, 2015

Conversation

@hoehleatsu
Copy link
Contributor

@hoehleatsu hoehleatsu commented Jul 23, 2015

There was an unintentional double negotation when checking on the number of columns.
(this is my first pull request, so I don't know if I follow the right procedure here by doing it like this)

There was an unintentional double negotation.
@hadley
Copy link
Member

@hadley hadley commented Jul 23, 2015

Thanks! Could you please also add a bullet point to NEWS describing the change?

@hoehleatsu
Copy link
Contributor Author

@hoehleatsu hoehleatsu commented Jul 23, 2015

With pleasure. I added a bullett to NEWS.md.

hadley added a commit that referenced this issue Jul 23, 2015
@hadley hadley merged commit f4a3956 into tidyverse:master Jul 23, 2015
1 check passed
@hadley
Copy link
Member

@hadley hadley commented Jul 23, 2015

Thanks!

@hoehleatsu hoehleatsu deleted the fwf_empty_bug branch Jul 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants