Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trim_ws argument to read_delim #312

Merged
merged 1 commit into from Jun 2, 2016
Merged

Add trim_ws argument to read_delim #312

merged 1 commit into from Jun 2, 2016

Conversation

@noamross
Copy link
Contributor

@noamross noamross commented Nov 13, 2015

No description provided.

@rudazhang
Copy link

@rudazhang rudazhang commented May 17, 2016

I'd like to see this commit merged! read_csv, read_csv2, and read_tsv all have this argument and are supposed to be special cases of the general read_delim function. So there's not reason for read_delim not to have it.

@hadley
Copy link
Member

@hadley hadley commented Jun 2, 2016

Looks good - can you please add a bullet to news?

@codecov-io
Copy link

@codecov-io codecov-io commented Jun 2, 2016

Current coverage is 75.79%

Merging #312 into master will increase coverage by 5.84%

@@             master    #312   diff @@
=======================================
  Files            56      44    -12   
  Lines          2802    2797     -5   
  Methods           0       0          
  Branches          0       0          
=======================================
+ Hits           1960    2120   +160   
+ Misses          842     677   -165   
  Partials          0       0          

Powered by Codecov. Last updated by 8312374...4251c86

@noamross
Copy link
Contributor Author

@noamross noamross commented Jun 2, 2016

Added and squashed

@hadley hadley merged commit 19d6eaf into tidyverse:master Jun 2, 2016
3 checks passed
@hadley
Copy link
Member

@hadley hadley commented Jun 2, 2016

Thanks!

@hadley hadley removed the in progress label Jun 2, 2016
rossholmberg pushed a commit to rossholmberg/pkgButterfly that referenced this issue Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants