New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subset col_types when there are too many; fixes #371 #372

Merged
merged 1 commit into from Jun 15, 2016

Conversation

Projects
None yet
4 participants
@jennybc
Member

jennybc commented Feb 24, 2016

The result is now what I expect, but seems like there should be problems? I don't know how to fix that.

(too_many <- read_csv("v1,v2\n1,2", col_types = "iii"))
#> Warning: Unnamed `col_types` should have the same length as `col_names`.
#> Using smaller of the two.
#>   v1 v2
#> 1  1  2
problems(too_many)
#> [1] row      col      expected actual  
#> <0 rows> (or 0-length row.names)

@jennybc jennybc force-pushed the jennybc:too-many-col-types branch from 0880b62 to 239ab01 Jun 2, 2016

@codecov-io

This comment has been minimized.

codecov-io commented Jun 2, 2016

Current coverage is 70.08%

Merging #372 into master will increase coverage by 0.19%

@@             master    #372   diff @@
=======================================
  Files            56      56          
  Lines          2801    2801          
  Methods           0       0          
  Branches          0       0          
=======================================
+ Hits           1957    1963     +6   
+ Misses          844     838     -6   
  Partials          0       0          

Powered by Codecov. Last updated by 6b7f2c2...491e641

@hadley

This comment has been minimized.

Member

hadley commented Jun 2, 2016

Is this the same problem as #298?

@hadley

This comment has been minimized.

Member

hadley commented Jun 9, 2016

@jimhester can you please review?

@jimhester

This comment has been minimized.

Member

jimhester commented Jun 15, 2016

LGTM and looks like the proper fix, @jennybc if you could just add a note to NEWS.md I think this can be merged.

#298 seems to be a separate problem, this change does not fix that issue.

@jennybc jennybc force-pushed the jennybc:too-many-col-types branch from 239ab01 to 2fb8e17 Jun 15, 2016

@jennybc

This comment has been minimized.

Member

jennybc commented Jun 15, 2016

Done.

@jimhester jimhester merged commit 1e00465 into tidyverse:master Jun 15, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@jennybc jennybc deleted the jennybc:too-many-col-types branch Mar 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment