Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addition of column names; fixes #373 #374

Merged
merged 1 commit into from Jun 2, 2016
Merged

Fix addition of column names; fixes #373 #374

merged 1 commit into from Jun 2, 2016

Conversation

jennybc
Copy link
Member

@jennybc jennybc commented Feb 26, 2016

Before:

library(readr)
(x <- read_csv("1,2,3,4\n", c("a", "b"), "iiii"))
#> Warning: Insufficient `col_names`. Adding 2 names.
#>   a b X4 X5
#> 1 1 2  3  4
(x <- read_csv("1,2,3\n", "a", "c_c"))
#> Warning: Insufficient `col_names`. Adding 1 names.
#>   a NA
#> 1 1  3

After:

load_all(".")
(x <- read_csv("1,2,3,4\n", c("a", "b"), "iiii"))
#> Warning: Insufficient `col_names`. Adding 2 names.
#>   a b X3 X4
#> 1 1 2  3  4
(x <- read_csv("1,2,3\n", "a", "c_c"))
#> Warning: Insufficient `col_names`. Adding 1 names.
#>   a X2
#> 1 1  3

@hadley
Copy link
Member

hadley commented Jun 1, 2016

Could you please add a bullet point to NEWS?

@codecov-io
Copy link

codecov-io commented Jun 2, 2016

Current coverage is 69.92%

Merging #374 into master will increase coverage by <.01%

@@             master    #374   diff @@
=======================================
  Files            56      56          
  Lines          2801    2803     +2   
  Methods           0       0          
  Branches          0       0          
=======================================
+ Hits           1957    1960     +3   
+ Misses          844     843     -1   
  Partials          0       0          

Powered by Codecov. Last updated by 6b7f2c2...1da94e0

@jennybc
Copy link
Member Author

jennybc commented Jun 2, 2016

Bullet added.

@hadley hadley merged commit be9131d into tidyverse:master Jun 2, 2016
@hadley
Copy link
Member

hadley commented Jun 2, 2016

Thanks!

@jennybc jennybc deleted the add-col-names branch June 2, 2016 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants